On Wed, 28 Oct 2009, Andi Kleen wrote:
> > + /*
> > + * If the bitmap cannot be listed in a buffer of length
> > + * APICID_LIST_LEN, then it is suffixed with "...".
> > + */
> > + len = bitmap_scnlistprintf(apicid_list, APICID_LIST_LEN,
> > + apicid_map, MAX_LOCAL_APIC);
> > + pr_info("SRAT: PXM %u -> APIC {%s%s} -> Node %u\n",
> > + i, apicid_list,
> > + (len == APICID_LIST_LEN - 1) ? "..." : "",
>
> Is the - 1 really correct? If scnlistprintf follows snprintf semantics then it would not
> be and my understanding is it is supposed to.
>
It is, bitmap_scnlistprintf() returns the number of characters printed to
the buffer minus the trailing '\0', which is different from snprintf().
APICID_LIST_LEN-1 then identifies when the buffer was max'd out. It still
adds a trailing "..." if the list is exactly 128 characters long, but this
isn't addressed to avoid added complexity.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
