> + /* > + * If the bitmap cannot be listed in a buffer of length > + * APICID_LIST_LEN, then it is suffixed with "...". > + */ > + len = bitmap_scnlistprintf(apicid_list, APICID_LIST_LEN, > + apicid_map, MAX_LOCAL_APIC); > + pr_info("SRAT: PXM %u -> APIC {%s%s} -> Node %u\n", > + i, apicid_list, > + (len == APICID_LIST_LEN - 1) ? "..." : "", Is the - 1 really correct? If scnlistprintf follows snprintf semantics then it would not be and my understanding is it is supposed to. Other than that it looks good. -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html