On Fri, Aug 28, 2009 at 9:33 PM, Len Brown<lenb@xxxxxxxxxx> wrote: > Thanks for the series Corentin, > it applied and built cleanly. > > Please go to > > http://patchwork.kernel.org/project/linux-acpi/list/?order=submitter > and mark the patches from Alan that you forwarded in state "Superceded" > so that I don't end up trying to apply them again when I get > to sifting through the many patches from Alan. Done for those present in my tree. Two patchs were not in my tree: http://patchwork.kernel.org/patch/42553/ http://patchwork.kernel.org/patch/42554/ I refreshed the first patch (a conflict due to "eeepc-laptop: add rfkill support for the Wimax in ASUS Eee PC 1000HG"), and merged the second. I'll send them in reply to this mail and mark them Superceded. > I fixed a couple of whitespace warnings like this: > WARNING: suspect code indent for conditional statements (8, 17) > #459: FILE: drivers/platform/x86/eeepc-laptop.c:1150: > + if (!device) > + return -EINVAL; > > please run checkpatch.pl on your patches before submitting > them so that we don't trip on trivial stuff like this. I usually do that, not this time, sorry :/ > This one is considered an actual error by the checkpatch maintainers: > > ERROR: do not use C99 // comments > #1466: FILE: drivers/platform/x86/asus-laptop.c:89: > +#define KEY_ON 0x200 //Keyboard backlight > > I left it alone since it was consistent with the existing code. > Please send a single patch to convert all of these at once. Done, Thanks, -- Corentin Chary http://xf.iksaif.net - http://uffs.org -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
