Re: [PATCH 00/24] acpi4asus update

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the series Corentin,
it applied and built cleanly.

Please go to

http://patchwork.kernel.org/project/linux-acpi/list/?order=submitter
and mark the patches from Alan that you forwarded in state "Superceded"
so that I don't end up trying to apply them again when I get
to sifting through the many patches from Alan.

I fixed a couple of whitespace warnings like this:
WARNING: suspect code indent for conditional statements (8, 17)
#459: FILE: drivers/platform/x86/eeepc-laptop.c:1150:
+	if (!device)
+		 return -EINVAL;

please run checkpatch.pl on your patches before submitting
them so that we don't trip on trivial stuff like this.

This one is considered an actual error by the checkpatch maintainers:

ERROR: do not use C99 // comments
#1466: FILE: drivers/platform/x86/asus-laptop.c:89:
+#define KEY_ON      0x200       //Keyboard backlight

I left it alone since it was consistent with the existing code.
Please send a single patch to convert all of these at once.

thanks,
Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux