On Wed, Aug 19, 2009 at 07:42:20PM +0800, Matthew Garrett wrote: > On Wed, Aug 19, 2009 at 03:24:21PM +0800, Shaohua Li wrote: > > > + ret = acpi_gpe_pme_check(dev); > > + > > + acpi_disable_gpe(dev->wakeup.gpe_device, dev->wakeup.gpe_number); > > I don't think we want to unconditionally disable the GPE. yes, we need something you proposed to add reference for GPE disable/enable. > > + > > + acpi_init_gpe_pme(); > > I'm also not keen on haing the notifier being at the ACPI level. Are we > guaranteed that the GPE will only be used for wakeups, and will never > trigger any other sort of notification? Keeping this at the bus level > may be more practical. the notification handler checks if this is a wakeup event. Because the ACPI wakeup event can be sent to any kind of buses, so move the code to acpi level can reduce a lot of duplicate code, otherwise you must implement the same mechanism for every bus. Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
