On Wed, Aug 19, 2009 at 03:24:21PM +0800, Shaohua Li wrote: > + ret = acpi_gpe_pme_check(dev); > + > + acpi_disable_gpe(dev->wakeup.gpe_device, dev->wakeup.gpe_number); I don't think we want to unconditionally disable the GPE. > + > + acpi_init_gpe_pme(); I'm also not keen on haing the notifier being at the ACPI level. Are we guaranteed that the GPE will only be used for wakeups, and will never trigger any other sort of notification? Keeping this at the bus level may be more practical. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html