Zhang, Rui wrote: > Hah, I nearly missed this email. > > Angelo, > Can you please re-send the refreshed patch so that I can add the comments in-line? > Better kick off a new thread with the title like "[PATCH] ACPI: ..." > > BTW: please don't send it as an attachment. :) > > Thanks > rui > >> -----Original Message----- >> From: Ângelo Miguel Arrifano [mailto:miknix@xxxxxxxxx] >> Sent: Monday, March 10, 2008 8:36 PM >> To: Zhang, Rui >> Cc: linux-acpi >> Subject: Re: *NEW* ACPI driver to support App Hot Startup AKA PNP0C32 - please >> apply >> >> On Mon, 10 Mar 2008 11:23:36 +0800 >> "Zhang, Rui" <rui.zhang@xxxxxxxxx> wrote: >> >>> As there is nothing private, add linux-acpi in the discussion. :) >> Ah, sorry. I was distracted. >>> On Fri, 2008-03-07 at 19:25 +0800, Ângelo Miguel Arrifano wrote: >>>> On Fri, 7 Mar 2008 14:27:13 +0800 >>>> "Zhang, Rui" <rui.zhang@xxxxxxxxx> wrote: >>>> >>>>> Hi, Angelo, >>>>> >>>>> For a typical ACPI device driver, it usually works like this: >>>>> 1. Register the ACPI device driver is the module_init >>>>> 2. Enable the device, create the sys I/F in the drivers .add method. >>>>> 3. Remove the device I/F in .remove method. >>>>> 4. unregister the ACPI device driver in module_exit. >>>>> >>>>> With your patch applied, the sys I/F will be created even if no >>>> PNP0C32 device exists in the ACPI namespace. IMO, moving this piece of >>>> code to the .add method will be much better. >>>> >>>> That's right, but the sys I/F being created are not in a per-device >>>> basis. I mean: >>>> >>>> Suppose PNP0C32 has three devices: >>>> ABTN >>>> BBTN >>>> CBTN >>> You mean three devices with _HID(PNP0C32), or three devices enumerated >>> under a PNP0C32 device? could you please attach the acpidump output? >> (...) >> >> Device (QBTN) >> { >> Name (_HID, EisaId ("PNP0C32")) >> Name (_UID, 0x01) >> Method (_STA, 0, NotSerialized) >> { >> If (LEqual (OSYS, 0x07D6)) >> { >> Return (0x0F) >> } >> Else >> { >> Return (0x00) >> } >> } >> >> Method (GHID, 0, NotSerialized) >> { >> If (LEqual (HOTB, 0x04)) >> { >> Notify (QBTN, 0x02) >> Store (0x00, HOTB) >> } >> >> Return (Buffer (0x01) >> { >> /* 0000 */ 0x01 >> }) >> } >> } >> >> >> >> Device (DBTN) >> { >> Name (_HID, EisaId ("PNP0C32")) >> Name (_UID, 0x02) >> Method (_STA, 0, NotSerialized) >> { >> If (LEqual (OSYS, 0x07D6)) >> { >> Return (0x0F) >> } >> Else >> { >> Return (0x00) >> } >> } >> >> Method (GHID, 0, NotSerialized) >> { >> If (LEqual (HOTB, 0x05)) >> { >> Notify (DBTN, 0x02) >> Store (0x00, HOTB) >> } >> >> Return (Buffer (0x01) >> { >> /* 0000 */ 0x02 >> }) >> } >> } >> >> (...) >> >> So the devices above are those whose I was referring as buttons. >> The first one is the QuickPlay button the second DVD Button, etc.. >> >>>> The sys files are created for PNP0C32 and not for every [ABC]BTN >>>> device. >>>> So, moving the >>>> sys I/F code into .add, AFAIK, will get the sys files created several >>>> times which is not >>>> the purpose. >>> .add method is called for each PNP0C32 device,not for each button. >>> so in this case, I think it will only create two sys files... >> Yeah, but PNP0C32 devices are the buttons. >> >>>> The sys files created are "buttons" and "pressed_button". >>>> "buttons" displays all devices (buttons) under PNP0C32 for, IMHO, >>>> easier enumeration by >>>> userspace; instead of having a file for each device. >>>> "pressed_buttons" displays the button used to turn on/resume the >>>> computer. >>>> >>>> But you are still right, the driver loads successfully (although >>>> displaying "none" on "buttons" sys file) when no PNP0C32 is present as >>>> we can see on this user post which doesn't have PNP0C32 at all: >>>> http://sourceforge.net/forum/forum.php?thread_id=1959640&forum_id=754264 >>>> >>>> On the code below, shouldn't (status < 0) be true when no PNP0C32 is >>>> present? >>>> >>>> /* ACPI driver register */ >>>> status = acpi_bus_register_driver(&quickstart_acpi_driver); >>>> if (status < 0) >>>> return -ENODEV; >>>> >>>> This was supposed to exit with -ENODEV before creating sys I/F. >>> No, acpi_bus_register_driver returns 0 if no matched device is found, in >>> order to support device hotplug. >> Hum.. Then this patch should prevent the module to load if no devices are present. >> >> --- quickstart/quickstart.c 2008-03-06 00:23:20.000000000 +0000 >> +++ quickstart-101/quickstart.c 2008-03-10 12:27:15.223132836 +0000 >> @@ -362,7 +362,7 @@ static int __init quickstart_init(void) >> >> /* ACPI driver register */ >> status = acpi_bus_register_driver(&quickstart_acpi_driver); >> - if (status < 0) >> + if (!quickstart_data.btn_lst || status < 0) >> return -ENODEV; >> >> /* Platform driver register */ >> >>> thanks, >>> rui >>> >> Best regards, >> -- >> Angelo Arrifano AKA MiKNiX >> CSE Student at UBI, Portugal >> Gentoo Linux AMD64 Arch Tester >> Linwizard Developer >> http://miknix.homelinux.com >> PGP Pubkey 0x3D92BB0B Hello all, I've been maintaining this driver, the latest tested tag is 2.6.28. However, I lost track of what is happening in the Linux ACPI tree. It seems it is moving towards ACPICA? Is there any interest on including this small piece of code in the tree? Best regards, - Angelo Arrifano -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
