Hi, Angelo, For a typical ACPI device driver, it usually works like this: 1. Register the ACPI device driver is the module_init 2. Enable the device, create the sys I/F in the drivers .add method. 3. Remove the device I/F in .remove method. 4. unregister the ACPI device driver in module_exit. With your patch applied, the sys I/F will be created even if no PNP0C32 device exists in the ACPI namespace. IMO, moving this piece of code to the .add method will be much better. BTW: please don't send a patch as an attachment, it's difficult for review. :) Thanks, rui >-----Original Message----- >From: linux-acpi-owner@xxxxxxxxxxxxxxx >[mailto:linux-acpi-owner@xxxxxxxxxxxxxxx] On Behalf Of ?ngelo Miguel Arrifano >Sent: Saturday, January 19, 2008 11:19 PM >To: lenb@xxxxxxxxxx >Cc: linux-acpi@xxxxxxxxxxxxxxx >Subject: Re: *NEW* ACPI driver to support App Hot Startup AKA PNP0C32 - please >apply > >-----BEGIN PGP SIGNED MESSAGE----- >Hash: SHA1 > >On Fri, 23 Nov 2007 15:24:46 +0000 >Ângelo Miguel Arrifano <miknix@xxxxxxxxx> wrote: > >> Hello all, >> >> I opened a SF.net project to support devices found under PNP0C32. >> These devices are known as Direct App Launch Buttons and are used on Vista >Hotstart(TM) technology. >> I believe most of Vista "ready" laptops have this. >> >> The project aims to provide similar functionality to Vista Hotstart(TM) in >linux. >> You can read more at http://quickstart.sourceforge.net/ >> >> Greetings, >> -- >> Angelo Arrifano AKA MiKNiX >> CSE Student at UBI, Portugal >> Gentoo Linux AMD64 Arch Tester >> miknix@xxxxxxxxx >> http://miknix.homelinux.com >> PGP Pubkey online >> >> - - >> >> Q: How many Chuck Norris' does it take to change a light bulb? >> A: None, Chuck Norris prefers to kill in the dark. > >The project is running for some time now. During this time there >were no reports of people getting it trouble with it. > >Attached is the patch. > >Thanks, >- -- >Angelo Arrifano AKA MiKNiX >CSE Student at UBI, Portugal >Gentoo Linux AMD64 Arch Tester >Linwizard Developer >miknix@xxxxxxxxx >http://miknix.homelinux.com >PGP Pubkey 0x3D92BB0B >-----BEGIN PGP SIGNATURE----- >Version: GnuPG v2.0.7 (GNU/Linux) > >iD8DBQFHkhUBNahyoD2SuwsRAn8gAJ4yj/kQl3RyAbBw3s9/2R04rEjFbQCfc1fC >/HlHqqB8B9my/vP67QMWrBM= >=nVRr >-----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
