Corentin Chary wrote: > On Sunday 24 May 2009 19:29:37 Alan Jenkins wrote: > >> Corentin Chary wrote: >> >>> On Sun, May 24, 2009 at 11:28 AM, Alan Jenkins >>> >>> <sourcejedi.lkml@xxxxxxxxxxxxxx> wrote: >>> >>>> On 5/16/09, Len Brown <lenb@xxxxxxxxxx> wrote: >>>> >>>>> From: Grigori Goronzy <greg@xxxxxxxxxxxx> >>>>> >>>>> The older eeepc-acpi driver allowed to control the SHE performance >>>>> preset through a ACPI function for just this purpose. SHE underclocks >>>>> and undervolts the FSB and undervolts the CPU (at preset 2, >>>>> "powersave"), or slightly overclocks the CPU (at preset 0, >>>>> "performance"). Preset 1 is the default setting with default clocks and >>>>> voltage. >>>>> >>>>> The new eeepc-laptop driver doesn't support it anymore. >>>>> The attached patch adds support for it to eeepc-laptop. It's very >>>>> straight-forward and almost trivial. >>>>> >>>>> Signed-off-by: Grigori Goronzy <greg@xxxxxxxxxxxx> >>>>> Signed-off-by: Corentin Chary <corentincj@xxxxxxxxxx> >>>>> Signed-off-by: Len Brown <len.brown@xxxxxxxxx> >>>>> --- >>>>> >>>> Hi, out of curiosity I tried this on my EeePC 701. I upgraded the >>>> BIOS to the latest version available a few months ago. >>>> >>>> I find that the file is present and can successfully be read from. >>>> The file returns the value "513". If I write "1" to it, nothing >>>> happens. If I write "0" to it, the speakers start hissing and the >>>> file then returns the value "512". Writing "1" again gets it back to >>>> normal. There is no apparent effect on performance. >>>> >>>> This is stupid, because we _do_ appear to check the BIOS supported >>>> features bitmask, but that's Asus firmware for you. Can you please >>>> add an extra test, so this file only allows reads or writes if the >>>> current value is 0 or 1? If you're quick you might slip it into -rc8 >>>> > > Hi, Can you try this patch ? It seems to works for me. > Thanks, it does make the interface less confusing. The behaviour (no performance change, hissing speakers) is the same. Do any of the models this actually works on, have only 2 different modes? I thought SHE included at least three, including an "overclocked" mode. Perhaps the cpufv file could be disabled for the 701 by checking the number of modes. I'm thinking about distributions designed for all EeePC models, which will want to include an SHE applet, but will want an easy way to avoid running it on the 701, where it can't work. BTW, is there a convention for sysfs files like this? You've used "*" to indicate the current value. /sys/power/disk uses square brackets instead. I see the "*" could be clearer though, when the options are single digits. Regards Alan -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
