On Tue, May 12, 2009 at 3:32 AM, Ingo Molnar <mingo@xxxxxxx> wrote: > > * Yinghai Lu <yinghai@xxxxxxxxxx> wrote: > >> + irq_attr->ioapic = apic; >> + irq_attr->ioapic_pin = mp_irqs[i].dstirq; >> + irq_attr->trigger = irq_trigger(i); >> + irq_attr->polarity = irq_polarity(i); > >> + irq_attr->ioapic = apic; >> + irq_attr->ioapic_pin = mp_irqs[i].dstirq; >> + irq_attr->trigger = irq_trigger(i); >> + irq_attr->polarity = irq_polarity(i); > > Shouldnt this be factored out ino a helper function? > set_io_apic_irq_attr()? YH -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
