On Monday 23 March 2009, Matthew Garrett wrote: > On Mon, Mar 23, 2009 at 07:20:12PM +0100, Rafael J. Wysocki wrote: > > On Monday 23 March 2009, Tian, Kevin wrote: > > > And then Xen jumps in to finish remaining steps. From this angle, > > > Xen is not a completely new platform and, well, S3 is more like a > > > 'S1' type from dom0's p.o.v with a different trigger method. Then is > > > it overkilled to introduce a new set of ops with 99% content > > > duplicated? > > > > IMO, no, it isn't. > > I'd disagree. Duplicating the code means remembering to apply bugfixes > to both parts. What code are you referring to exactly? The callbacks that are literally the same can be pointed to by the new set of operations just fine. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html