On Wed, 2009-03-11 at 01:10 +0800, Matthew Garrett wrote:
> On Tue, Mar 10, 2009 at 04:03:34PM +0800, Zhang Rui wrote:
> > if (level == device->brightness->levels[state]) {
> > - device->backlight->props.brightness = state - 2;
> > + if (device->backlight)
> > + device->backlight->props.brightness = state - 2;
>
> This hunk doesn't seem obviously related?
I need to set the backlight in acpi_video_init_brightness, before video
backlight device being registered.
>
> > + * For now, we don't support the _BCL like this:
> > + * 16, 15, 0, 1, 2, 3, ..., 14, 15, 16
> > + * because we may mess up the index returned by _BQC.
> > + * Plus: we have not got a box like this.
>
> Do we have any bugs that suggest there are boxes like this?
>
No, we don't have one.
So we should remove this check unless we've one _BCL like this?
thanks,
rui
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
