Re: [RFC PATCH 5/5] ACPI video: support _BQC/_BCL/_BCM methods that use index values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 10, 2009 at 04:03:34PM +0800, Zhang Rui wrote:
>  		if (level == device->brightness->levels[state]) {
> -			device->backlight->props.brightness = state - 2;
> +			if (device->backlight)
> +				device->backlight->props.brightness = state - 2;

This hunk doesn't seem obviously related?

> +			 * For now, we don't support the _BCL like this:
> +			 * 16, 15, 0, 1, 2, 3, ..., 14, 15, 16
> +			 * because we may mess up the index returned by _BQC.
> +			 * Plus: we have not got a box like this.

Do we have any bugs that suggest there are boxes like this?

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux