On Mon, Mar 09, 2009 at 02:00:09PM +0000, Matthew Garrett wrote: > On Mon, Mar 09, 2009 at 03:52:42PM +0200, Ville Syrjälä wrote: > > > If you think this using common sense I think the following would be the > > most obvious mapping: > > sleep = STR, hibernate = STD, suspend = preferred suspend mode > > I agree, but this isn't a discussion about user-visible nomenclature - > it's a discussion about using the keycodes we have in the kernel. The > aim is to ensure that everyone in-kernel uses the correct codes, and if > we can do that without breaking existing userspace (even if it means the > nomenclature differs) then that's preferable. I don't think that invalidates my point. There's always the possibility of re-creating the same mess in the future if the definitions aren't crystal clear. The less room there is for personal interpretation of the definitions the better. I understand that backwards compatibility is critical but perhaps that is reason enough to create a completely a new set of definitions and just map the old definitions in the best way possible. Something like this? KEY_SUSPEND_TO_RAM KEY_SUSPEND_TO_DISK KEY_SUSPEND_TO_PREFERRED -- Ville Syrjälä syrjala@xxxxxx http://www.sci.fi/~syrjala/ -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
