On Sun, Mar 08, 2009 at 11:19:35PM +0000, Matthew Garrett wrote: > On Sun, Mar 08, 2009 at 04:07:50PM -0700, Dmitry Torokhov wrote: > > > - KEY_SLEEP - leave the keycode, the action should be the default > > system state defined by either platform or user. I expect that the vast > > majority of system have default state similar to S3 so there should not > > be anysurprises. > > > > - KEY_SUSPEND - provide better comment for its intended usage and maybe > > add KEY_HIBERNATE alias. > > > > - KEY_SUSPEND2RAM - add a new definition. > > > > Do you think this would this work? > > I think that would be fine, though I'm not entirely convinced that we > need KEY_SUSPEND2RAM as a separate keycode. If you think this using common sense I think the following would be the most obvious mapping: sleep = STR, hibernate = STD, suspend = preferred suspend mode Both sleep and hibernate are biological processes and the difference between them should be obvious for everyone. Suspend on that other hand just says that your work is suspended. I don't know if common sense has any room in these discussions though. I would at least avoid mixing the suspend2ram and hibernate definitions. The first one comes from the technical aspect and the second comes from the biological aspect so mixing them IMO just creates more confusion. Of course the API is a technical thing anyway so perhaps just go for something explicit like suspend2ram, suspend2disk and suspend2preferred. The old definitions would of course need to be mapped to the new definitions somehow. -- Ville Syrjälä syrjala@xxxxxx http://www.sci.fi/~syrjala/ -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
