On Sat, Mar 7, 2009 at 3:44 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Sat, Mar 07, 2009 at 06:38:53PM +0300, Andrey Borzenkov wrote: > >> - patch toshiba_acpi to return KEY_SUSPEND/KEY_HIBERNATE instead of >> KEY_SLEEP/KEY_SUSPEND. This depends on commit >> 6932b918e05b06165ed3457a9f3aa279099a7cbd in linux-next. >> >> - patch HAL to recognize KEY_HIBERNATE and return "suspend" for >> KEY_SUSPEND; right now it is: >> >> [KEY_SLEEP] = "sleep", >> [KEY_SUSPEND] = "hibernate", > > Ugh. Why are we changing this? The semantics were pretty clear before. > The KEY_SUSPEND to hibernate mapping was decided years ago, and it's > clearly an incompatible change as far as userspace goes. See my mails to linux-acpi. Hibernate = sleep to disk, suspend = sleep to ram, and sleep = sleep type not indicated or unknown. This is how it is in Xorg and the session now. Mapping KEY_SUSPEND to hibernate is just insane. Can you please change the toshiba driver to use KEY_HIBERNATE and KEY_SUSPEND as thinkpad now does? Thanks. Richard. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
