On 21.2.2009 05:58, Len Brown wrote:
On Sun, 15 Feb 2009, Jiri Slaby wrote:
There was a misplaced status test. Move it to correct place and
rollback appropriately.
hmm, looks like this has been broken since the day
acpi_os_initialize1() was invented in 2004.
It comes from bitkeeper times, I checked, it looked like a typo.
Turns out that the bug and its fix are moot, however,
as acpi_os_initialize1() is hard-coded to return success,
opting for BUG_ON() if it sees a failure...
BUG_ON is not noreturn e.g. on embedded, anyway it would crash later in
this case. I was thinking about returning a failure when one of them is
NULL, but fell back to not do so and check only retval in the caller.
So unless that changes, I'd prefer to keep the code
simple and just not check its status -- which is effectively
what we're doing right now.
Ok, no problem. Will repost.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
