On Wednesday 11 February 2009, Jiri Slaby wrote: > On 02/11/2009 09:51 AM, Jiri Slaby wrote: > > On 02/11/2009 01:36 AM, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > >> The mm-of-the-moment snapshot 2009-02-10-16-35 has been uploaded > > > > Hi, > > > > I've found out, that S4 disappeared in this release, in comparison to mmotm > > based on 2.6.29-rc2: > > -ACPI: (supports S0 S1 S3 S4 S5) > > +ACPI: (supports S0 S1 S3 S5) > > > > Any ideas what could have caused this? > > I think this one > ARCH_HIBERNATION_POSSIBLE=n > because > SMP=y > since > config ARCH_HIBERNATION_POSSIBLE > def_bool y > - depends on !SMP || !X86_VOYAGER > + depends on !SMP > > The condition was wrong, ok, anyway it worked. Would > depends on !SMP || EXPERIMENTAL > make sense? The smp is handled in disable_nonboot_cpus manner, right? Ah, someone removed X86_VOYAGER and left this gem. I guess that went in through -tip (Ingo CCed). After removing X86_VOYAGER, ARCH_HIBERNATION_POSSIBLE should always be set on x86. Just make it config ARCH_HIBERNATION_POSSIBLE def_bool y Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html