On Wed, 4 Feb 2009, Frans Pop wrote: > On Wednesday 04 February 2009, Geert Uytterhoeven wrote: > > > This patch looks broken to me, at least for some of your changes. > > > For example, in the bit quoted above all printks together make up > > > *one single* message, which means that only the _first_ of the > > > printks should have the KERN_* prefix. printks that are continuations > > > should not have the prefix. > > > > Actually they should, but the right prefix :-) > > Hmm. I was going by memory and from what I've seen in existing code, but > also found this (somewhat old) post: > https://lists.linux-foundation.org/pipermail/kernel-janitors/2005-October/014375.html That one predates KERN_CONT. > > Quoting include/linux/kernel.h: > > | /* > > | * Annotation for a "continued" line of log printout (only done after a > > | * line that had no enclosing \n). Only to be used by core/arch code > > | * during early bootup (a continued line is not SMP-safe otherwise). > > | */ > > | #define KERN_CONT "" > > > > Please also consider the note about SMP-safeness. > > From that it looks like KERN_CONT should only be used in a very limited > context, but I guess this example qualifies. Yep, the general advise is to avoid using continuations. With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@xxxxxxxxxxx Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
