On Wed, 4 Feb 2009, Frans Pop wrote: > Frank Seidel wrote: > > +++ b/drivers/acpi/pci_link.c > > @@ -593,7 +593,7 @@ static int acpi_pci_link_allocate(struct > > return -ENODEV; > > } else { > > acpi_irq_penalty[link->irq.active] += PIRQ_PENALTY_PCI_USING; > > - printk(PREFIX "%s [%s] enabled at IRQ %d\n", > > + printk(KERN_WARNING PREFIX "%s [%s] enabled at IRQ %d\n", > > acpi_device_name(link->device), > > acpi_device_bid(link->device), link->irq.active); > > } > > @@ -751,21 +751,21 @@ static int acpi_pci_link_add(struct acpi > > acpi_device_bid(device)); > > for (i = 0; i < link->irq.possible_count; i++) { > > if (link->irq.active == link->irq.possible[i]) { > > - printk(" *%d", link->irq.possible[i]); > > + printk(KERN_INFO " *%d", link->irq.possible[i]); > > found = 1; > > } else > > - printk(" %d", link->irq.possible[i]); > > + printk(KERN_INFO " %d", link->irq.possible[i]); > > } > > > > - printk(")"); > > + printk(KERN_INFO ")"); > > > > if (!found) > > - printk(" *%d", link->irq.active); > > + printk(KERN_INFO " *%d", link->irq.active); > > > > This patch looks broken to me, at least for some of your changes. > For example, in the bit quoted above all printks together make up > *one single* message, which means that only the _first_ of the > printks should have the KERN_* prefix. printks that are continuations > should not have the prefix. Actually they should, but the right prefix :-) Quoting include/linux/kernel.h: | /* | * Annotation for a "continued" line of log printout (only done after a | * line that had no enclosing \n). Only to be used by core/arch code | * during early bootup (a continued line is not SMP-safe otherwise). | */ | #define KERN_CONT "" Please also consider the note about SMP-safeness. With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@xxxxxxxxxxx Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html