Re: [PATCH 2.6.29] fujitsu-laptop: Add BL power, LED control and

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi


Am Samstag, den 03.01.2009, 22:57 +0000 schrieb Tony Vroon:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Peter Gruber wrote:
> > Tested it on the S6410, and works as expected
> 
> On the subject of the S6410 (and S6420, which I have), I believe I can
> simplify the backlight handling a *LOT*. Peter, to confirm that, could

On the subject of removing stuff I think we can definitely remove the
BLNF checking stuff (since the "empty table signature support" is in the
acpi-implementation of the kernel for some time now)


Peter

diff --git a/drivers/misc/fujitsu-laptop.c b/drivers/misc/fujitsu-laptop.c
index a7dd3e9..7839367 100644
--- a/drivers/misc/fujitsu-laptop.c
+++ b/drivers/misc/fujitsu-laptop.c
@@ -438,8 +438,6 @@ static void dmi_check_cb_common(const struct dmi_system_id *id)
        int have_blnf;
        printk(KERN_INFO "fujitsu-laptop: Identified laptop model '%s'.\n",
               id->ident);
-       have_blnf = ACPI_SUCCESS
-           (acpi_get_handle(NULL, "\\_SB.PCI0.GFX0.LCD.BLNF", &handle));
        if (use_alt_lcd_levels == -1) {
                vdbg_printk(FUJLAPTOP_DBG_TRACE, "auto-detecting usealt\n");
                use_alt_lcd_levels = 1;
@@ -447,12 +445,12 @@ static void dmi_check_cb_common(const struct dmi_system_id *id)
        if (disable_brightness_keys == -1) {
                vdbg_printk(FUJLAPTOP_DBG_TRACE,
                            "auto-detecting disable_keys\n");
-               disable_brightness_keys = have_blnf ? 1 : 0;
+               disable_brightness_keys = 1;
        }
        if (disable_brightness_adjust == -1) {
                vdbg_printk(FUJLAPTOP_DBG_TRACE,
                            "auto-detecting disable_adjust\n");
-               disable_brightness_adjust = have_blnf ? 0 : 1;
+               disable_brightness_adjust = 0;
        }
 }
 



--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux