Re: [PATCH 2.6.29] fujitsu-laptop: Add BL power, LED control and

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

> Tested it on the S6410, and works as expected

Thanks for confirming.

> perhaps we should shorten the driver name a little to make it a bit more
> inline with the other acpi drivers:
> # ls /sys/bus/acpi/drivers
> ac       container  Fujitsu laptop FUJ02B1 ACPI brightness driver
> pci_link processor  thermal
> battery  ec         Fujitsu laptop FUJ02E3 ACPI hotkeys driver
> pci_root sbs        video
> button   fan        hpet
> power    smbus_hc
> 
> What do you think?

I assume you're talking about the textual driver name as opposed to the
module name ("fujitsu-laptop").  I have no immediate thoughts regarding
this.  Personally I quite like the extended information the above output
gives since you're left in no doubt where the driver comes from.  Is there a
general convenction that the driver names reported in /sys/bus/acpi/drivers
are restricted to a single word?  If so I'm happy to do up a patch to
comply, but at the same time if there's no thought one way or the other then
perhaps the existing name could stay.

Having said that, there's probably no harm in dropping "FUJ02B1 ACPI" and
"FUJ02E3 ACPI".  The FUJ* isn't really interesting for most users, and
the fact that it's an ACPI driver is self-evident from other things.

Regards
  jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux