-- Len Brown, Intel Open Source Technology Center
> Random example - i dont think stuff like this is readable [in to-be
> kernel/acpi/utilities/utcache.c]:
>
> if (cache->current_depth >= cache->max_depth) {
> ACPI_FREE(object);
> ACPI_MEM_TRACKING(cache->total_freed++);
> }
>
> /* Otherwise put this object back into the cache */
>
> else {
> status = acpi_ut_acquire_mutex(ACPI_MTX_CACHES);
> if (ACPI_FAILURE(status)) {
> return (status);
> }
Oops, I notice that I skipped over this comment.
It is a good example of needed cleanup.
(I proposed moving this to kernel/acpi/acpica/, not
kernel/acpi/utilities/)
But the Linux kernel doesn't compile the contents of utcache.c
and indeed, I should delete that entire file from the tree.
Linux compiles this in osl.c instead:
acpi_status acpi_os_release_object(acpi_cache_t * cache, void *object)
{
kmem_cache_free(cache, object);
return (AE_OK);
}
thanks for pointing this out, I'll deal with it right now.
-Len
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
