Re: [patch] ACPI: make debug command-line arguments work again

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> >  /* Debug switch - level and trace mask */
> > -u32 acpi_dbg_level = ACPI_DEBUG_DEFAULT;
> > +u32 acpi_dbg_level = ACPI_LV_INFO;

> This is acpica code.
> If this one is/can be touched, then we should modify
> ACPI_DEBUG_DEFAULT directly? (see patch in the end)
> 
> >
> >  /* Debug switch - layer (component) mask */
> >
> > -u32 acpi_dbg_layer = ACPI_COMPONENT_DEFAULT | ACPI_ALL_DRIVERS;
> > +u32 acpi_dbg_layer = 0;
> IMO we should keep dbg_layer high and only lower the level.
> Like that you only have to fiddle with one param for general
> debugging (e.g. when requesting info in a bug report).
> 
> This is what should be in OpenSUSE for quite a while.
> init seems not to be used.

Actually, ACPI_DB_INIT _is_ used -- it is what prints
out those annoying dots...

I'll be happy to see it off by default.

thanks,
-- Len Brown, Intel Open Source Technology Center

> --- include/acpi/acoutput.h.bak	2008-11-14 18:53:33.000000000 +0100
> +++ include/acpi/acoutput.h	2008-11-14 18:53:48.000000000 +0100
> @@ -172,7 +172,7 @@
>  
>  /* Defaults for debug_level, debug and normal */
>  
> -#define ACPI_DEBUG_DEFAULT          (ACPI_LV_INIT | ACPI_LV_DEBUG_OBJECT)
> +#define ACPI_DEBUG_DEFAULT          (ACPI_LV_INIT)
>  #define ACPI_NORMAL_DEFAULT         (ACPI_LV_INIT | ACPI_LV_DEBUG_OBJECT)
>  #define ACPI_DEBUG_ALL              (ACPI_LV_AML_DISASSEMBLE | ACPI_LV_ALL_EXCEPTIONS | ACPI_LV_ALL)

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux