On Friday 14 November 2008 10:57:55 am Thomas Renninger wrote: > On Friday 14 November 2008 00:30:13 Bjorn Helgaas wrote: > > /* Debug switch - level and trace mask */ > > -u32 acpi_dbg_level = ACPI_DEBUG_DEFAULT; > > +u32 acpi_dbg_level = ACPI_LV_INFO; > This is acpica code. > If this one is/can be touched, then we should modify > ACPI_DEBUG_DEFAULT directly? (see patch in the end) I don't have a strong opinion either way. If Len doesn't want to carry such a patch, I suggested that maybe the OSPM could supply #defines for the default values. > > /* Debug switch - layer (component) mask */ > > > > -u32 acpi_dbg_layer = ACPI_COMPONENT_DEFAULT | ACPI_ALL_DRIVERS; > > +u32 acpi_dbg_layer = 0; > IMO we should keep dbg_layer high and only lower the level. > Like that you only have to fiddle with one param for general > debugging (e.g. when requesting info in a bug report). It's a trade-off between whether you want to debug the ACPI core or drivers. I made it so you only need one parameter (layer) when debugging drivers, because that's what I've found most useful. The drivers only use ACPI_LV_INFO. Turning on all the layers seems to generate a lot of unrelated output, e.g., "info" messages from all over the CA, the core, and drivers. To me, that seems less useful than zeroing in on a specific area. > This is what should be in OpenSUSE for quite a while. > init seems not to be used. > > --- include/acpi/acoutput.h.bak 2008-11-14 18:53:33.000000000 +0100 > +++ include/acpi/acoutput.h 2008-11-14 18:53:48.000000000 +0100 > @@ -172,7 +172,7 @@ > > /* Defaults for debug_level, debug and normal */ > > -#define ACPI_DEBUG_DEFAULT (ACPI_LV_INIT | ACPI_LV_DEBUG_OBJECT) > +#define ACPI_DEBUG_DEFAULT (ACPI_LV_INIT) > #define ACPI_NORMAL_DEFAULT (ACPI_LV_INIT | ACPI_LV_DEBUG_OBJECT) > #define ACPI_DEBUG_ALL (ACPI_LV_AML_DISASSEMBLE | ACPI_LV_ALL_EXCEPTIONS | ACPI_LV_ALL) > > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
