[Andi Kleen - Thu, Aug 21, 2008 at 08:46:12AM +0200] | akpm@xxxxxxxxxxxxxxxxxxxx writes: | | > From: Cyrill Gorcunov <gorcunov@xxxxxxxxx> | > | > The early_param handling function could recieve NULL pointer as argument | > in case if user didn't enter parameter value. So we have to be ready for | > a such situation and do check for NULL pointer if needed. | > | > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxx> | > Cc: Andi Kleen <andi@xxxxxxxxxxxxxx> | > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> | | Queued for 2.6.27. Thanks. | | But I wonder if it wouldn't be generally safer for the caller to just pass | an empty string instead of NULL in this case? | | -Andi | Actually this would require to patch kernel code not in one place. There was some discusion about this http://lkml.org/lkml/2008/8/12/229 - in short it could lead to hidden bug since not all users of early_param are ready for this and they have to be checked. - Cyrill - -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
