On Thu, 2008-08-07 at 20:53 -0600, Matthew Wilcox wrote: > On Fri, Aug 08, 2008 at 11:28:49AM +1000, Dave Chinner wrote: > > > completion_done is an abomination. Stop this. > > > > Say what? > > > > You've had several opportunities to comment on that *you suggested* > > [1]. You did not respond to any of them when it was being discussed > > 6 weeks ago and subsequent resends [2] and now you're saying what > > you suggested is an abortion? > > Sorry, I had it confused with these: > > http://oss.sgi.com/archives/xfs/2008-06/msg00372.html I was just saying that completions should be used for resource counting. Like the usage in drivers/usb/usb-skeleton.c, sema_init(&dev->limit_sem, WRITES_IN_FLIGHT); This writes in flight usage happens 5-10 times in Linux, and completion can fit that usage model .. It's not really locking, it's just counting. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
