On Thu, Aug 07, 2008 at 06:34:08PM -0600, Matthew Wilcox wrote: > On Thu, Aug 07, 2008 at 07:59:43AM -0700, Daniel Walker wrote: > > The semaphore usage in ACPI is more like completions. The ASL > > functions getting implemented here are signals which follow a > > "wait for", signaled, or reset format. > > > > This implements the ACPI signaling methods with the Linux > > completion API, instead of using semaphores. > > > > completion_done() taken from Dave Chinner. > > completion_done is an abomination. Stop this. Say what? You've had several opportunities to comment on that *you suggested* [1]. You did not respond to any of them when it was being discussed 6 weeks ago and subsequent resends [2] and now you're saying what you suggested is an abortion? What's the problem? The implementation, the interface, or something else? [1] http://oss.sgi.com/archives/xfs/2008-06/msg00380.html [2] http://oss.sgi.com/archives/xfs/2008-06/msg00382.html http://oss.sgi.com/archives/xfs/2008-06/msg00400.html http://oss.sgi.com/archives/xfs/2008-07/msg00173.html Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html