On Thu, 2008-08-07 at 18:34 -0600, Matthew Wilcox wrote: > On Thu, Aug 07, 2008 at 07:59:43AM -0700, Daniel Walker wrote: > > The semaphore usage in ACPI is more like completions. The ASL > > functions getting implemented here are signals which follow a > > "wait for", signaled, or reset format. > > > > This implements the ACPI signaling methods with the Linux > > completion API, instead of using semaphores. > > > > completion_done() taken from Dave Chinner. > > completion_done is an abomination. Stop this. > In my ACPI changes it's just used for a BUG_ON to trigger if there is something waiting on the completion before the memory gets free'd .. You don't like how it's used, or you don't like the code itself? Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html