Re: Check for ACPI backlight support otherwise use vendor ACPI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi gyys

> I didi some testing and found whats wrong with the backlight detection
> in video_detect.c you should change:
> 
> --- video_detect.c 2008-07-31 17:20:59.540059897 +0200
> +++ video_detect.c 2008-07-31 17:22:15.752034851 +0200
> @@ -45,9 +45,9 @@
>  		ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Found generic backlight "
>  				  "support\n"));
>  		*cap |= ACPI_VIDEO_BACKLIGHT;
> -		return 0;
> +		return -ENODEV;
>  	}
> -	return -ENODEV;
> +	return 0;
>  }
>  
> 
> otherwise it stops walking the subtree at the first device which does
> not contain backlight (in my case GFX0 has CRT_ as first child which
> does not support backlight).

Makes sense to me (although admittedly I haven't looked deeply into it). 
Are there likely to be any obscure side effects on other hardware which
for some reason assumes backlight support is on the first device scanned?

I'll try to find some time over the weekend to make sure this causes no
ill-effects on the S7020.  It shouldn't, but you never know.

> BTW. the DRDY detection (for IGD) works ... now I have to find the IGD
> patches ... couldn't find them on the list and the version of linux-next
> I tried didn't contain anything which looked like it.

Unfortunately I don't know of a definitive source for these either.

Regards
  jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux