Re: [PATCH] Panasonic Let's Note laptop extras driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 02, 2008 at 11:19:19AM +0100, Matthew Garrett wrote:

> > +		if (acpi_pcc_hotkey_get_key(hotkey)) {
> > +			/* generate event like '"pcc HKEY 00000080 00000084"'
> > +			 * when Fn+F4 pressed */
> 
> Probably better not to add further events to /proc now - we'd like to 
> deprecate the interface.

the userspace scripts that acpid ships already support those events.  So
if the kernel driver provides events in this way, the brightness changes
will work out-of-the-box.

So I vote for keeping those events in the driver - just as long as there
is no new standard mechanism for signalling brightness up/down button
events to userspace.

I was pondering to emulate the events that the "video" acpi class
driver sends to userspace.  But that also doesn't really seems right the
correct solution.

-- 
- Harald Welte <laforge@xxxxxxxxxxxx>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux