On Wed, Jul 02, 2008 at 09:03:15PM +0800, Harald Welte wrote: > Hi Matthew, > > > > Hm. Does this mean that the keymap isn't changable at runtime? > > i wasn't aware that those kind of keymaps could be changeable at > runtime. Will read up on my homework ;) Especially when you have a case where there's a scancode that isn't mapped to anything by default, it's helpful to let it be changed at runtime. I usually just copy the code from wistron_btns whenever I'm implementing this. > > And shouldn't be adding any new files to /proc. Anything that can't be > > expressed via the existing generic sysfs classes should be an attribute > > on a sysfs platform device. > > that's what I generally know from other drivers (and how I do it in > other kernel code). But I wasn't sure what the policy with regard to > this was for ACPI. The long-term goal is to kill off /proc/acpi entirely, so adding new things is kind of frowned upon :) -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html