Hi! > +static struct pci_platform_pm_ops *pci_platform_pm; > + > +int pci_set_platform_pm(struct pci_platform_pm_ops *ops) > +{ > + if (!ops->is_manageable || !ops->set_state || !ops->choose_state) > + return -EINVAL; > + pci_platform_pm = ops; > + return 0; > +} BUG_ON? It is programmer error if we see NULLs here, right? (And those programmers will be exactly those not checking the return value). Otherwise looks ok to me. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html