On Tue, 2008-06-24 at 13:52 +0200, Vegard Nossum wrote: > On 6/24/08, Ingo Molnar <mingo@xxxxxxx> wrote: > > i havent seen the warning reappear with your fix after thousands of > > bootups - so i guess we can consider it fixed. > > > > Len, please consider the patch below. (it's in tip/out-of-tree) > > No, please don't :-) > > It fixes your particular case (the acpi_rtc_init() hunk of the patch), > but the acpi_walk_namespace() part should be changed to a WARN(). But > that is likely to cause a lot of "spurious" reports, so the other acpi > drivers should be fixed as well. In fact this issue is related with the following factors: a. when acpi is disabled, OS won't initialize the ACPI mutex, which is accessed by many ACPI interface functions. For example: acpi_walk_namespace, acpi_install_fixed_event_handler. b. When acpi is disabled, some drivers will call the ACPI interface functions. For example: The acpi_walk_namespace is called in dock_init/bay_init. The acpi_install_fixed_event_handler is called in the acpi_rtc_init. Although the following warning message is harmless, it is still confusing. > [ 3.980213] ACPI Exception (utmutex-0263): AE_BAD_PARAMETER, Thread F7C50000 could not acquire Mutex [3] [20080321] Maybe it is reasonable that the flag of acpi_disabled should be used in the drivers using ACPI interface functions. Of course it will be safe to use the flag of acpi_disabled in the function of acpi_walk_namespace. Thanks. Yakui. > I was waiting for Len to reply, but maybe I can submit the proper fix too. > > > Vegard > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
