On Tuesday 24 June 2008 5:52:55 am Vegard Nossum wrote: > On 6/24/08, Ingo Molnar <mingo@xxxxxxx> wrote: > > i havent seen the warning reappear with your fix after thousands of > > bootups - so i guess we can consider it fixed. > > > > Len, please consider the patch below. (it's in tip/out-of-tree) > > No, please don't :-) > > It fixes your particular case (the acpi_rtc_init() hunk of the patch), > but the acpi_walk_namespace() part should be changed to a WARN(). But > that is likely to cause a lot of "spurious" reports, so the other acpi > drivers should be fixed as well. > > I was waiting for Len to reply, but maybe I can submit the proper fix too. I haven't looked into the acpi_walk_namespace() question. But I did look at the acpi_rtc_init() stuff, and I have to say it looks like a really round-about way to accomplish this. I'd rather just fold in the FADT accesses directly into cmos_do_probe() and dispense with the stuff in drivers/acpi/glue.c. I'm working on a couple patches along this line, but it will take me a few days to finish up. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
