Re: [patch 06/11] misc,acpi,backlight: compal Laptop Extras

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dnia 2008-06-10, o godz. 22:28:59
Richard Purdie <rpurdie@xxxxxxxxx> napisał(a):

> On Tue, 2008-06-10 at 12:55 -0400, Len Brown wrote:
> > 
> > On Mon, 9 Jun 2008, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > 
> > > From: Cezary Jackiewicz <cezary.jackiewicz@xxxxxxxxx>
> > > 
> > > This is driver for Compal Laptop: FL90/IFL90, based on MSI driver.
> > > 
> > > This driver exports a few files in /sys/devices/platform/compal-laptop/:
> > >  lcd_level - screen brightness: contains a single integer in the range 0..7 (rw)
> > 
> > why is it a good idea to implement this platform specific lcd_level API
> > and at the same time implement the generic backlight API?
> 
> I've asked about this before and suggested the lcd_level attribute be
> removed since the backlight API does everything that attribute does in a
> standardised way. I never did get a response.
> 

Driver was rewritten from original msi driver, so this attribute was also
copied. I can remove it in a future version and use only standard backlight API.

-- 
 Cezary
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux