On Tue, 10 Jun 2008 12:14:08 -0400 (EDT)
Len Brown <lenb@xxxxxxxxxx> wrote:
>
>
> On Mon, 9 Jun 2008, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
>
> > From: Ingo Molnar <mingo@xxxxxxx>
> >
> > x86.git testing found the following build bug:
> >
> > drivers/built-in.o: In function `acpi_rtc_init':
> > glue.c:(.init.text+0x16c3): undefined reference to `pnp_bus_type'
> >
> > this tries to use PNP bus infrastructure even in the !PNP case.
> >
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> > Cc: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >
> > drivers/acpi/glue.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff -puN drivers/acpi/glue.c~acpi-fix-drivers-acpi-gluec-build-error drivers/acpi/glue.c
> > --- a/drivers/acpi/glue.c~acpi-fix-drivers-acpi-gluec-build-error
> > +++ a/drivers/acpi/glue.c
> > @@ -303,6 +303,7 @@ static void rtc_wake_off(struct device *
> >
> > static struct cmos_rtc_board_info rtc_info;
> >
> > +#ifdef CONFIG_PNP
> >
> > /* PNP devices are registered in a subsys_initcall();
> > * ACPI specifies the PNP IDs to use.
> > @@ -364,4 +365,6 @@ static int __init acpi_rtc_init(void)
> > /* do this between RTC subsys_initcall() and rtc_cmos driver_initcall() */
> > fs_initcall(acpi_rtc_init);
> >
> > +#endif /* CONFIG_PNP */
> > +
> > #endif
>
> ENOREPRODUCE
>
> I'm unable to convince "make oldconfig" to allow a
> CONFIG_ACPI=y CONFIG_PNP=n build.
>
ick, look at this thing:
Symbol: PNP [=y]
Prompt: Plug and Play support
Defined at drivers/pnp/Kconfig:5
Depends on: HAS_IOMEM && (ISA || ACPI)
Location:
-> Device Drivers
Selected by: ACPI && !X86_VOYAGER && !X86_NUMAQ && !X86_VISWS && !IA64_HP_SIM && (IA64 || X86) && PCI && PM
it's rather reliant upon select working as desired, which it often
doesn't.
Ingo usually provides a link to the offending .config, but this time he
didn't?
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
