>-----Original Message----- >From: Borislav Petkov <bp@xxxxxxxxx> >Sent: 03 March 2025 10:35 >To: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx> >Cc: Shiju Jose <shiju.jose@xxxxxxxxxx>; linux-edac@xxxxxxxxxxxxxxx; linux- >acpi@xxxxxxxxxxxxxxx; rafael@xxxxxxxxxx; tony.luck@xxxxxxxxx; >lenb@xxxxxxxxxx; mchehab@xxxxxxxxxx; linux-mm@xxxxxxxxx; linux- >kernel@xxxxxxxxxxxxxxx; linux-cxl@xxxxxxxxxxxxxxx; j.williams@xxxxxxxxx; >dave@xxxxxxxxxxxx; dave.jiang@xxxxxxxxx; alison.schofield@xxxxxxxxx; >vishal.l.verma@xxxxxxxxx; ira.weiny@xxxxxxxxx; david@xxxxxxxxxx; >Vilas.Sridharan@xxxxxxx; leo.duran@xxxxxxx; Yazen.Ghannam@xxxxxxx; >rientjes@xxxxxxxxxx; jiaqiyan@xxxxxxxxxx; Jon.Grimm@xxxxxxx; >dave.hansen@xxxxxxxxxxxxxxx; naoya.horiguchi@xxxxxxx; >james.morse@xxxxxxx; jthoughton@xxxxxxxxxx; somasundaram.a@xxxxxxx; >erdemaktas@xxxxxxxxxx; pgonda@xxxxxxxxxx; duenwen@xxxxxxxxxx; >gthelen@xxxxxxxxxx; wschwartz@xxxxxxxxxxxxxxxxxxx; >dferguson@xxxxxxxxxxxxxxxxxxx; wbs@xxxxxxxxxxxxxxxxxxxxxx; >nifan.cxl@xxxxxxxxx; tanxiaofei <tanxiaofei@xxxxxxxxxx>; Zengtao (B) ><prime.zeng@xxxxxxxxxxxxx>; Roberto Sassu <roberto.sassu@xxxxxxxxxx>; >kangkang.shen@xxxxxxxxxxxxx; wanghuiqiang <wanghuiqiang@xxxxxxxxxx>; >Linuxarm <linuxarm@xxxxxxxxxx> >Subject: Re: [PATCH linux-next 0/2] ACPI: Add support for ACPI RAS2 feature >table > [...] > >However, just from a cursory look, it would need some scrubbing. There's stuff >like: > >+ ps_sm->params.requested_address_range[0] = 0; >+ ps_sm->params.requested_address_range[1] = 0; >+ ps_sm->params.scrub_params_in &= >~RAS2_PATROL_SCRUB_SCHRS_IN_MASK; >+ ps_sm->params.scrub_params_in |= >FIELD_PREP(RAS2_PATROL_SCRUB_SCHRS_IN_MASK, >+ ras2_ctx->scrub_cycle_hrs); >+ ps_sm->params.patrol_scrub_command = >+ RAS2_START_PATROL_SCRUBBER; > > >which definitely needs shortening. There's no need for a wholly written out >"requested_address_range". I know variables should have meaningfull names >but writing fiction shouldn't be either. Hi Borislav, Some of these variables, for e.g. requested_address_range are not defined in this patch, but in the 'include/acpi/actbl2.h'. My understanding is that those changes required to upstream first via https://github.com/acpica/acpica ? > >+static int ras2_acpi_parse_table(struct acpi_table_header *pAcpiTable) > >Yuck, CamelCase?! Fixed. > >And I'm pretty sure if I start looking more, I'll find more funky stuff. Will check and fix. > >HTH. > >-- >Regards/Gruss, > Boris. > >https://people.kernel.org/tglx/notes-about-netiquette Thanks, Shiju
