On Thu, 2008-04-10 at 20:46 -0700, David Brownell wrote: > On Friday 11 April 2008, Zhao Yakui wrote: > > But The following is reasonable. IMO. > > For October: 0x0A will be written into the RTC region > > (MONTH_ALARM). But in fact 0x10 should be written. > > /* Writing 0xff means "don't care" or "match all". */ > > > > - mon = t->time.tm_mon; > > - mon = (mon < 12) ? BIN2BCD(mon) : 0xff; > > - mon++; > > + mon = t->time.tm_mon + 1; > > + mon = (mon <= 12) ? BIN2BCD(mon) : 0xff; > > > > Is there an opportunity to merge it? > > Sure. Submit that as a patch by itself. > How about the following issue? There is another question about the driver rtc and rtc-cmos. rtc driver is in drivers/char/ and rtc-cmos is in drivers/rtc/ On some laptops the two drivers will share the same memory/irq resource, which will cause that rtc-cmos driver can't work well after the rtc driver is already loaded.(Of course RTC sys I/F isn't created in rtc driver.) How to solve this issue? Best regards Yakui > - Dave > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
