Re: [RFC] [PATCH 1/3] Allow to override the RTC alarm time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 11 April 2008, Zhao Yakui wrote:
> But The following is reasonable. IMO.
>  For October: 0x0A will be written into the RTC region
> (MONTH_ALARM). But in fact 0x10 should be written.
>        /* Writing 0xff means "don't care" or "match all".  */
>  
> -       mon = t->time.tm_mon;
> -       mon = (mon < 12) ? BIN2BCD(mon) : 0xff;
> -       mon++;
> +       mon = t->time.tm_mon + 1;
> +       mon = (mon <= 12) ? BIN2BCD(mon) : 0xff;
> 
> Is there an opportunity to merge it?

Sure.  Submit that as a patch by itself.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux