On Mon, Aug 26, 2024 at 04:13:57PM -0500, Mario Limonciello wrote: > From: Mario Limonciello <mario.limonciello@xxxxxxx> > > Don't take and release the mutex when prefcore isn't present and > avoid initialization of variables that will be initially set > in the function. > > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx> > --- > drivers/cpufreq/amd-pstate.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index 75568d0f84623..ed05d7a0add10 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -798,17 +798,17 @@ static void amd_pstate_update_limits(unsigned int cpu) > int ret; > bool highest_perf_changed = false; > > - mutex_lock(&amd_pstate_driver_lock); > - if ((!amd_pstate_prefcore) || (!cpudata->hw_prefcore)) > - goto free_cpufreq_put; > + if (!amd_pstate_prefcore) > + return; Looks good to me. Wondering if it is worth maintaining a static key for amd_pstate_prefcore. Anyway it doesn't change after boot. Reviewed-by: Gautham R. Shenoy <gautham.shenoy@xxxxxxx> -- Thanks and Regards gautham.
