Re: [PATCH v2 2/2] ACPI: PM: Use max() for clearer D3 state selection in acpi_dev_pm_get_state

["Rafael J. Wysocki" <rafael@xxxxxxxxxx>]

On Wed, Jun 26, 2024 at 3:14 PM Prabhakar Pujeri
<prabhakar.pujeri@xxxxxxxxx> wrote:
>
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@xxxxxxxxx>
> ---
>  drivers/acpi/device_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c
> index 3b4d048c4941..a90ae059fb60 100644
> --- a/drivers/acpi/device_pm.c
> +++ b/drivers/acpi/device_pm.c
> @@ -760,7 +760,7 @@ static int acpi_dev_pm_get_state(struct device *dev, struct acpi_device *adev,
>                         if (!adev->power.states[ret].flags.valid)
>                                 ret = ACPI_STATE_D3_COLD;
>
> -                       d_max = ret > d_min ? ret : d_min;
> +                       d_max = max(ret, d_min);

You need to use max_t() here.

>                 } else {
>                         return -ENODATA;
>                 }
> --