Hi, On Mon, Apr 29, 2024 at 4:55 PM Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> wrote: > > Hi, > > There's a bug that is caused by an EmbeddedControl OpRegion which is > declared inside the scope of a specific USB Type-C device (PNP0CA0): > https://bugzilla.kernel.org/show_bug.cgi?id=218789 And in this bug you are essentially proposing to install the EC OpRegion handler at the namespace root instead of the EC device. This sounds reasonable, although AFAICS this is a matter of modifying the EC driver (before the EC OpRegion handler is installed by the EC drvier, ACPICA has no way to handle EC address space accesses anyway). > It looks like that's not the only case where that OpRegion ID is used > outside of the EC device scope. There is at least one driver in Linux > Kernel (drivers/platform/x86/wmi.c) that already has a custom handler > for the EmbeddedControl OpRegion, and based on a quick search, the > problem "Region EmbeddedControl (ID=3) has no handler" has happened > with some other devices too. AFAICS, installing the EC address space handler at the EC device object itself is not based on any sound technical arguments, it's just been always done this way in Linux. It's quite possible that the EC address space handler should have been installed at the namespace root from the outset. Thanks!
