On Friday, 21 of March 2008, Johannes Berg wrote: > > > + * All of the above callbacks, except for @complete(), return error codes. > > + * However, the error codes returned by the resume operations, @resume(), > > + * @thaw(), and @restore(), are only printed in the system logs, since the PM > > + * core cannot do anything else about them. > > Why bother and not just make them return void, the error printing can > most likely be done much much better in the callback since that possibly > has information on why it failed. > > > + * All of the above callbacks, return error codes, but the error codes returned > > + * by the resume operations, @resume_noirq(), @thaw_noirq(), and > > + * @restore_noirq(), are only printed in the system logs, since the PM core > > + * cannot do anything else about them. > > Same here, of course. The errors returned are used by TRACE_RESUME(), for example. Well, perhaps the comments should be changed instead. :-) Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
