On Mon, 26 Feb 2024 16:27:01 -0600 Ben Cheatham <Benjamin.Cheatham@xxxxxxx> wrote: > Change the EINJ module to install a platform device/driver on module > init and move the module init() and exit() functions to driver probe and > remove. This change allows the EINJ module to load regardless of whether > setting up EINJ succeeds, which allows dependent modules to still load > (i.e. the CXL core). > > Since EINJ may no longer be initialized when the module loads, any > functions that are called from dependent/external modules should check > the einj_initialized variable before calling any EINJ functions. > > Signed-off-by: Ben Cheatham <Benjamin.Cheatham@xxxxxxx> Looks good to me. Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> I did wonder if a debug message was needed on no acpi support given that should be really really obvious on a system, but I guess with late probing of this from a module, maybe that is still useful. Jonathan
