On 2/27/24 11:47 PM, Dan Williams wrote: > Ben Cheatham wrote: >> Change the EINJ module to install a platform device/driver on module >> init and move the module init() and exit() functions to driver probe and >> remove. This change allows the EINJ module to load regardless of whether >> setting up EINJ succeeds, which allows dependent modules to still load >> (i.e. the CXL core). >> >> Since EINJ may no longer be initialized when the module loads, any >> functions that are called from dependent/external modules should check >> the einj_initialized variable before calling any EINJ functions. > > Is this statement true given that no debugfs files are registered when > einj_initialized() is false? > That's true, I guess this would just be for redundancy/extra safety. > It would be nice to remove that from the functions and just rely on > debugfs files not being published for safety. > I'll go ahead and remove those checks. > With that fixed up you can add: > > Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
