Re: [PATCH v2 2/2] Revert "ACPI: PM: Block ASUS B1400CEAE from suspend to idle by default"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Rafael J. Wysocki <rafael@xxxxxxxxxx> 於 2024年2月7日 週三 下午6:30寫道:
>
> On Wed, Feb 7, 2024 at 10:09 AM Jian-Hong Pan <jhp@xxxxxxxxxxxxx> wrote:
> >
> > Daniel Drake <drake@xxxxxxxxxxxxx> 於 2024年2月7日 週三 下午4:45寫道:
> > >
> > > This reverts commit d52848620de00cde4a3a5df908e231b8c8868250, which
> > > was originally put in place to work around a s2idle failure on this
> > > platform where the NVMe device was inaccessible upon resume.
> > >
> > > After extended testing, we found that the firmware's implementation of
> > > S3 is buggy and intermittently fails to wake up the system. We need
> > > to revert to s2idle mode.
> > >
> > > The NVMe issue has now been solved more precisely in the commit titled
> > > "PCI: Disable D3cold on Asus B1400 PCI-NVMe bridge"
> > >
> > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=215742
> > > Signed-off-by: Daniel Drake <drake@xxxxxxxxxxxxx>
> >
> > Signed-off-by: Jian-Hong Pan <jhp@xxxxxxxxxxxxx>
>
> What is this tag supposed to mean?
>
> In a reply to a patch, you can give Acked-by, Reviewed-by or
> Tested-by.  Which one do you mean?

Ok!  Then, Acked-by: Jian-Hong Pan <jhp@xxxxxxxxxxxxx>

> > > ---
> > >  drivers/acpi/sleep.c | 12 ------------
> > >  1 file changed, 12 deletions(-)
> > >
> > > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c
> > > index 808484d112097..728acfeb774d8 100644
> > > --- a/drivers/acpi/sleep.c
> > > +++ b/drivers/acpi/sleep.c
> > > @@ -385,18 +385,6 @@ static const struct dmi_system_id acpisleep_dmi_table[] __initconst = {
> > >                 DMI_MATCH(DMI_PRODUCT_NAME, "20GGA00L00"),
> > >                 },
> > >         },
> > > -       /*
> > > -        * ASUS B1400CEAE hangs on resume from suspend (see
> > > -        * https://bugzilla.kernel.org/show_bug.cgi?id=215742).
> > > -        */
> > > -       {
> > > -       .callback = init_default_s3,
> > > -       .ident = "ASUS B1400CEAE",
> > > -       .matches = {
> > > -               DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> > > -               DMI_MATCH(DMI_PRODUCT_NAME, "ASUS EXPERTBOOK B1400CEAE"),
> > > -               },
> > > -       },
> > >         {},
> > >  };
> > >
> > > --





[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]
  Powered by Linux