On Thu, Dec 21, 2023 at 04:47:59PM -0700, Raul Rangel wrote: > On Thu, Dec 21, 2023 at 4:46 PM Mark Hasemeyer <markhas@xxxxxxxxxxxx> wrote: > > > > > -int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int > > index) > > > > +int fwnode_irq_get_resource(const struct fwnode_handle *fwnode, > > > > + unsigned int index, struct resource *r) > > > > > > It's perfectly fine to replace ) by , on the previous line, no need > > > to make it shorter. > > > > That puts the line at 115 chars? checkpatch.pl allows a maximum line > > length of 100. I can bump the 'index' argument up a line and keep it > > to a length of 95? > > clang-format should do the right thing. Sorry, but no. It has some interesting results sometimes. Like any other tool it has to be used with caution and common sense. If it works in the particular case, fine. -- With Best Regards, Andy Shevchenko