On Wed, Dec 20, 2023 at 04:54:34PM -0700, Mark Hasemeyer wrote:
> The underlying ACPI and OF subsystems provide their own APIs which
> provide IRQ information as a struct resource. This allows callers to get
> more information about the IRQ by looking at the resource flags. For
Double space when other lines have a single space.
> example, whether or not an IRQ is wake capable.
Suggested-by?
...
> -int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index)
> +int fwnode_irq_get_resource(const struct fwnode_handle *fwnode,
> + unsigned int index, struct resource *r)
It's perfectly fine to replace ) by , on the previous line, no need
to make it shorter.
...
> +int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index)
> +{
> + struct resource r;
struct resource r = {};
?
> + return fwnode_irq_get_resource(fwnode, index, &r);
> +}
--
With Best Regards,
Andy Shevchenko
