On Tue, 4 Mar 2008 16:47:27 -0700 Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote: > Convert quirk printks to dev_printk(). > > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@xxxxxx> > > Index: linux-mm/drivers/pnp/quirks.c > =================================================================== > --- linux-mm.orig/drivers/pnp/quirks.c 2008-03-04 16:41:17.000000000 -0700 > +++ linux-mm/drivers/pnp/quirks.c 2008-03-04 16:44:00.000000000 -0700 > @@ -51,7 +51,8 @@ > port3->min += 0x800; > port3->max += 0x800; > } > - printk(KERN_INFO "pnp: AWE32 quirk - adding two ports\n"); > + dev_info(&dev->dev, "AWE32 quirk - added ioports 0x%lx and 0x%lx\n", > + (unsigned long) port2->min, (unsigned long) port3->min); > } drivers/pnp/quirks.c: In function 'quirk_awe32_resources': drivers/pnp/quirks.c:25: warning: 'port3' may be used uninitialized in this function drivers/pnp/quirks.c:25: warning: 'port2' may be used uninitialized in this function the warning is correct, methinks. If dev->dependent happens to be NULL, we oops. I'll just move the dev_info() inside the loop, which is more logical and is actually correct. The code at present will only print the last-added ports? -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
